Revert "Start supporting edit forms for any document type."

This reverts commit 6845bd06bf.

src/components/RelationshipList.tsx

@@ -3,7 +3,7 @@ import { pb } from "@/lib/pocketbase";
 import type { Document, RelationshipType } from "@/lib/types";
 import { useState } from "react";
 import { Loader } from "./Loader";
-import { NewRelatedDocumentForm } from "./documents/NewRelatedDocumentForm";
+import { DocumentForm } from "./documents/DocumentForm";
 import { DocumentRow } from "./documents/DocumentRow";
 
 interface RelationshipListProps {
@@ -68,7 +68,7 @@ export function RelationshipList({
       error={error}
       renderRow={(document) => <DocumentRow document={document} />}
       newItemForm={(onSubmit) => (
-        <NewRelatedDocumentForm
+        <DocumentForm
           campaignId={root.campaign}
           relationshipType={relationshipType}
           onCreate={async (doc: Document) => {

src/components/documents/DocumentForm.tsx

@@ -7,13 +7,13 @@ import { SecretForm } from "./secret/SecretForm";
 import { TreasureForm } from "./treasure/TreasureForm";
 
 function assertUnreachable(_x: never): never {
-  throw new Error("NewRelatedDocumentForm switch is not exhaustive");
+  throw new Error("DocumentForm switch is not exhaustive");
 }
 
 /**
  * Renders a form for any document type depending on the relationship.
  */
-export const NewRelatedDocumentForm = ({
+export const DocumentForm = ({
   campaignId,
   relationshipType,
   onCreate,
@@ -24,27 +24,19 @@ export const NewRelatedDocumentForm = ({
 }) => {
   switch (relationshipType) {
     case RelationshipType.Locations:
-      return (
+      return <LocationForm campaign={campaignId} onCreate={onCreate} />;
-        <LocationForm
-          target={{
-            type: "new",
-            campaignId,
-          }}
-          onSubmit={onCreate}
-        />
-      );
     case RelationshipType.Monsters:
       return <MonsterForm campaign={campaignId} onCreate={onCreate} />;
     case RelationshipType.Npcs:
       return <NpcForm campaign={campaignId} onCreate={onCreate} />;
     case RelationshipType.Secrets:
       return <SecretForm campaign={campaignId} onCreate={onCreate} />;
+    case RelationshipType.DiscoveredIn:
+      return "Form not supported here";
     case RelationshipType.Treasures:
       return <TreasureForm campaign={campaignId} onCreate={onCreate} />;
     case RelationshipType.Scenes:
       return <SceneForm campaign={campaignId} onCreate={onCreate} />;
-    case RelationshipType.DiscoveredIn:
-      return "Form not supported here";
   }
 
   return assertUnreachable(relationshipType);

src/components/documents/Forms.ts

@@ -1,12 +0,0 @@
-import type { CampaignId, Document } from "@/lib/types";
-
-export type FormTarget<T extends Document> =
-  | {
-      type: "new";
-      campaignId: CampaignId;
-      document?: undefined;
-    }
-  | {
-      type: "existing";
-      document: T;
-    };

src/components/documents/location/LocationForm.tsx

@@ -1,22 +1,19 @@
 import { useState } from "react";
-import type { Location } from "@/lib/types";
+import type { CampaignId, Location } from "@/lib/types";
 import { pb } from "@/lib/pocketbase";
-import type { FormTarget } from "../Forms";
 
 /**
  * Renders a form to add a new location. Calls onCreate with the new location document.
  */
 export const LocationForm = ({
-  target,
+  campaign,
-  onSubmit,
+  onCreate,
 }: {
-  target: FormTarget<Location>;
+  campaign: CampaignId;
-  onSubmit: (location: Location) => Promise<void>;
+  onCreate: (location: Location) => Promise<void>;
 }) => {
-  const [name, setName] = useState(target.document?.data.location.name ?? "");
+  const [name, setName] = useState("");
-  const [description, setDescription] = useState(
+  const [description, setDescription] = useState("");
-    target.document?.data.location.description ?? "",
-  );
   const [adding, setAdding] = useState(false);
   const [error, setError] = useState<string | null>(null);
 
@@ -26,9 +23,8 @@ export const LocationForm = ({
     setAdding(true);
     setError(null);
     try {
-      if (target.type === "new") {
       const locationDoc: Location = await pb.collection("documents").create({
-          campaign: target.campaignId,
+        campaign,
         data: {
           location: {
             name,
@@ -38,20 +34,7 @@ export const LocationForm = ({
       });
       setName("");
       setDescription("");
-        await onSubmit(locationDoc);
+      await onCreate(locationDoc);
-      } else {
-        const locationDoc: Location = await pb
-          .collection("documents")
-          .update(target.document.id, {
-            data: {
-              location: {
-                name,
-                description,
-              },
-            },
-          });
-        await onSubmit(locationDoc);
-      }
     } catch (e: any) {
       setError(e?.message || "Failed to add location.");
     } finally {